Skip to content

lv-tool: Upgrade default actor plugin to "lv_gltest" if available - #178

Merged
hartwork merged 2 commits into
masterfrom
lv-tool-default-actor-upgrade
Jan 18, 2023
Merged

hartwork merged 2 commits into
masterfrom
lv-tool-default-actor-upgrade

Conversation

@hartwork

Copy link
Copy Markdown
Member

This is a foward port of 0.4.x commit e4a6cf5 from pull request #150 to master.

@hartwork hartwork added this to the 0.5.0 milestone Jan 17, 2023
@hartwork
hartwork requested a review from kaixiong January 17, 2023 22:04

/**
* Creates a new Actor with a plugin of a given name.
*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this is a good idea. Can we move this into a separate patch and add the method to LV::Morph and LV::Input as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaixiong done 👍

@hartwork
hartwork force-pushed the lv-tool-default-actor-upgrade branch from e4cd4c7 to b4627cb Compare January 18, 2023 15:35
@hartwork
hartwork requested a review from kaixiong January 18, 2023 15:35

@kaixiong kaixiong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartwork, thanks. Can you insert a space between the available() and its argument list, like this:

if (!available (name)) {

@hartwork
hartwork force-pushed the lv-tool-default-actor-upgrade branch from b4627cb to 60ad4af Compare January 18, 2023 16:40
@hartwork

Copy link
Copy Markdown
Member Author

@hartwork, thanks. Can you insert a space between the available() and its argument list, like this:

if (!available (name)) {

@kaixiong done

@hartwork
hartwork requested a review from kaixiong January 18, 2023 16:40

@kaixiong kaixiong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartwork, all good to go.

@hartwork
hartwork merged commit 2f1aa5e into master Jan 18, 2023
@hartwork
hartwork deleted the lv-tool-default-actor-upgrade branch January 18, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants